feat: added python-version-strategy config option, to enable enforcing use of the lowest supported (approximate) version #775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g use of the lowest supported (approximate) version
This was referenced Dec 6, 2023
winlover32
approved these changes
Jan 19, 2024
ErikBjare
commented
Jan 20, 2024
| @@ -73,6 +74,9 @@ function resolveVersionInput() { | |||
| } | |||
| } | |||
|
|
|||
| if(versionStrategy == "approximate") | |||
There was a problem hiding this comment.
Might be better to make the versionStrategy directly take ~ as an argument, so that it can be used for all kinds of version overrides.
Not sure if there are uses for overriding the strategy to ^ however.
winlover32
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adds a
python-version-strategyconfig option that enables overriding the version-picking strategy provided by the Python version specifier from>=and^to~.This is very useful when the version specified in
python-version-fileis a version constraint such as^3.8but where you usually want to test against the lowest supported version (with the highest patch version).Related issue:
Filed a feature request for this here: #774
Check list:
PRs I will merge if this change is accepted:
python_versionmatrix var with `python-version-file: p… ActivityWatch/aw-core#124python-version-fileActivityWatch/aw-client#80python_versionmatrix var with `python-version-file: p… ActivityWatch/aw-qt#101python_versionmatrix var with `python-version-file: p… ActivityWatch/aw-server#148python_versionmatrix var with `python-version-file: p… ActivityWatch/aw-watcher-afk#65python_versionmatrix var with `python-version-file: p… ActivityWatch/aw-watcher-window#93python_versionmatrix var with `python-version-file: p… ActivityWatch/aw-watcher-input#29